From 4db04b7a227fff13701b64e4cd9daf5f93ce48a6 Mon Sep 17 00:00:00 2001
From: Trevor Bossert <37596773+tabossert@users.noreply.github.com>
Date: Fri, 3 Nov 2023 16:10:22 -0700
Subject: [PATCH] ci(test): remove environment identifier (#2003)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Moved Azure OIDC to use only Pull Request subject, this gets rid of the
noise it creates in the PR’s
---
 .github/workflows/ci.yml                      |  2 -
 .../ingest-test-fixtures-update-pr.yml        | 40 -------------------
 2 files changed, 42 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f28a5756a..5134634e9 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -313,7 +313,6 @@ jobs:
 
 
   test_ingest_src:
-    environment: ci
     strategy:
       matrix:
         python-version: ["3.8","3.9","3.10","3.11"]
@@ -400,7 +399,6 @@ jobs:
 
 
   test_ingest_dest:
-    environment: ci
     strategy:
       matrix:
         python-version: ["3.8","3.9","3.10","3.11"]
diff --git a/.github/workflows/ingest-test-fixtures-update-pr.yml b/.github/workflows/ingest-test-fixtures-update-pr.yml
index ac710b658..e4ded6ea0 100644
--- a/.github/workflows/ingest-test-fixtures-update-pr.yml
+++ b/.github/workflows/ingest-test-fixtures-update-pr.yml
@@ -12,31 +12,6 @@ permissions:
   contents: read
 
 jobs:
-  test_logins:
-    runs-on: ubuntu-latest
-    environment: ci
-    steps:
-      - uses: 'actions/checkout@v4'
-      - name: 'Google Cloud Auth'
-        uses: 'google-github-actions/auth@v1'
-        id: gauth
-        with:
-          workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}
-          service_account: ${{ secrets.GCP_SERVICE_ACCOUNT }}
-      - name: 'Set up Cloud SDK'
-        uses: 'google-github-actions/setup-gcloud@v1'
-      - name: 'run gcloud command'
-        run: |-
-          gcloud projects list
-      - name: 'Az CLI login'
-        uses: azure/login@v1
-        with:
-          client-id: ${{ secrets.AZURE_CLIENT_ID }}
-          tenant-id: ${{ secrets.AZURE_TENANT_ID }}
-          subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
-      - name: 'azure test command'
-        run: |-
-          az account show
   setup:
     runs-on: ubuntu-latest-m
     env:
@@ -100,7 +75,6 @@ jobs:
           make install-all-ingest
 
   update-fixtures-and-pr:
-    environment: ci
     runs-on: ubuntu-latest-m
     env:
       NLTK_DATA: ${{ github.workspace }}/nltk_data
@@ -108,20 +82,6 @@ jobs:
     steps:
       # actions/checkout MUST come before auth
       - uses: 'actions/checkout@v4'
-      - name: 'Google Cloud Auth'
-        uses: 'google-github-actions/auth@v1'
-        with:
-          workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}
-          service_account: ${{ secrets.GCP_SERVICE_ACCOUNT }}
-          create_credentials_file: true
-      - name: 'Set up Cloud SDK'
-        uses: 'google-github-actions/setup-gcloud@v1'
-      - name: 'Az CLI login'
-        uses: azure/login@v1
-        with:
-          client-id: ${{ secrets.AZURE_CLIENT_ID }}
-          tenant-id: ${{ secrets.AZURE_TENANT_ID }}
-          subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v4
         with: