Fix: remove fake api key in test (#762)

* no fake api key

* changlog and version

* remove kwarg since we have default
This commit is contained in:
Yuming Long 2023-06-15 15:18:22 -04:00 committed by GitHub
parent a9b9b873b1
commit 5bf78c077d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 17 deletions

View File

@ -1,4 +1,4 @@
## 0.7.6-dev1 ## 0.7.6-dev2
### Enhancements ### Enhancements
@ -13,6 +13,7 @@
### Fixes ### Fixes
* Remove fake api key in test `partition_via_api` since we now require valid/empty api keys
* Page number defaults to `None` instead of `1` when page number is not present in the metadata. * Page number defaults to `None` instead of `1` when page number is not present in the metadata.
A page number of `None` indicates that page numbers are not being tracked for the document A page number of `None` indicates that page numbers are not being tracked for the document
or that page numbers do not apply to the element in question.. or that page numbers do not apply to the element in question..

View File

@ -49,7 +49,7 @@ def test_partition_via_api_from_filename(monkeypatch):
lambda *args, **kwargs: MockResponse(status_code=200), lambda *args, **kwargs: MockResponse(status_code=200),
) )
filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "fake-email.eml") filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "fake-email.eml")
elements = partition_via_api(filename=filename, api_key="FAKEROO") elements = partition_via_api(filename=filename)
assert elements[0] == NarrativeText("This is a test email to use for unit tests.") assert elements[0] == NarrativeText("This is a test email to use for unit tests.")
assert elements[0].metadata.filetype == "message/rfc822" assert elements[0].metadata.filetype == "message/rfc822"
@ -63,7 +63,7 @@ def test_partition_via_api_from_file(monkeypatch):
filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "fake-email.eml") filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "fake-email.eml")
with open(filename, "rb") as f: with open(filename, "rb") as f:
elements = partition_via_api(file=f, file_filename=filename, api_key="FAKEROO") elements = partition_via_api(file=f, file_filename=filename)
assert elements[0] == NarrativeText("This is a test email to use for unit tests.") assert elements[0] == NarrativeText("This is a test email to use for unit tests.")
assert elements[0].metadata.filetype == "message/rfc822" assert elements[0].metadata.filetype == "message/rfc822"
@ -77,7 +77,7 @@ def test_partition_via_api_from_file_raises_without_filename(monkeypatch):
filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "fake-email.eml") filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "fake-email.eml")
with open(filename, "rb") as f, pytest.raises(ValueError): with open(filename, "rb") as f, pytest.raises(ValueError):
partition_via_api(file=f, api_key="FAKEROO") partition_via_api(file=f)
def test_partition_via_api_raises_with_bad_response(monkeypatch): def test_partition_via_api_raises_with_bad_response(monkeypatch):
@ -89,20 +89,20 @@ def test_partition_via_api_raises_with_bad_response(monkeypatch):
filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "fake-email.eml") filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "fake-email.eml")
with pytest.raises(ValueError): with pytest.raises(ValueError):
partition_via_api(filename=filename, api_key="FAKEROO") partition_via_api(filename=filename)
def test_partition_via_api_valid_request_data_kwargs(): def test_partition_via_api_valid_request_data_kwargs():
filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "layout-parser-paper-fast.pdf") filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "layout-parser-paper-fast.pdf")
elements = partition_via_api(filename=filename, api_key="", strategy="fast") elements = partition_via_api(filename=filename, strategy="fast")
assert isinstance(elements, list) assert isinstance(elements, list)
def test_partition_via_api_invalid_request_data_kwargs(): def test_partition_via_api_invalid_request_data_kwargs():
filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "layout-parser-paper-fast.pdf") filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "layout-parser-paper-fast.pdf")
with pytest.raises(ValueError): with pytest.raises(ValueError):
partition_via_api(filename=filename, api_key="FAKEROO", strategy="not_a_strategy") partition_via_api(filename=filename, strategy="not_a_strategy")
class MockMultipleResponse: class MockMultipleResponse:
@ -164,7 +164,7 @@ def test_partition_multiple_via_api_with_single_filename(monkeypatch):
) )
filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "fake-email.eml") filename = os.path.join(DIRECTORY, "..", "..", "example-docs", "fake-email.eml")
elements = partition_multiple_via_api(filenames=[filename], api_key="FAKEROO") elements = partition_multiple_via_api(filenames=[filename])
assert elements[0][0] == NarrativeText("This is a test email to use for unit tests.") assert elements[0][0] == NarrativeText("This is a test email to use for unit tests.")
assert elements[0][0].metadata.filetype == "message/rfc822" assert elements[0][0].metadata.filetype == "message/rfc822"
@ -181,7 +181,7 @@ def test_partition_multiple_via_api_from_filenames(monkeypatch):
os.path.join(DIRECTORY, "..", "..", "example-docs", "fake.docx"), os.path.join(DIRECTORY, "..", "..", "example-docs", "fake.docx"),
] ]
elements = partition_multiple_via_api(filenames=filenames, api_key="FAKEROO") elements = partition_multiple_via_api(filenames=filenames)
assert len(elements) == 2 assert len(elements) == 2
assert elements[0][0] == NarrativeText("This is a test email to use for unit tests.") assert elements[0][0] == NarrativeText("This is a test email to use for unit tests.")
assert elements[0][0].metadata.filetype == "message/rfc822" assert elements[0][0].metadata.filetype == "message/rfc822"
@ -204,7 +204,6 @@ def test_partition_multiple_via_api_from_files(monkeypatch):
elements = partition_multiple_via_api( elements = partition_multiple_via_api(
files=files, files=files,
file_filenames=filenames, file_filenames=filenames,
api_key="FAKEROO",
) )
assert len(elements) == 2 assert len(elements) == 2
assert elements[0][0] == NarrativeText("This is a test email to use for unit tests.") assert elements[0][0] == NarrativeText("This is a test email to use for unit tests.")
@ -224,7 +223,7 @@ def test_partition_multiple_via_api_raises_with_bad_response(monkeypatch):
] ]
with pytest.raises(ValueError): with pytest.raises(ValueError):
partition_multiple_via_api(filenames=filenames, api_key="FAKEROO") partition_multiple_via_api(filenames=filenames)
def test_partition_multiple_via_api_raises_with_content_types_size_mismatch(monkeypatch): def test_partition_multiple_via_api_raises_with_content_types_size_mismatch(monkeypatch):
@ -243,7 +242,6 @@ def test_partition_multiple_via_api_raises_with_content_types_size_mismatch(monk
partition_multiple_via_api( partition_multiple_via_api(
filenames=filenames, filenames=filenames,
content_types=["text/plain"], content_types=["text/plain"],
api_key="FAKEROO",
) )
@ -266,7 +264,6 @@ def test_partition_multiple_via_api_from_files_raises_with_size_mismatch(monkeyp
files=files, files=files,
file_filenames=filenames, file_filenames=filenames,
content_types=["text/plain"], content_types=["text/plain"],
api_key="FAKEROO",
) )
@ -287,7 +284,6 @@ def test_partition_multiple_via_api_from_files_raises_without_filenames(monkeypa
with pytest.raises(ValueError): with pytest.raises(ValueError):
partition_multiple_via_api( partition_multiple_via_api(
files=files, files=files,
api_key="FAKEROO",
) )
@ -297,7 +293,7 @@ def test_partition_multiple_via_api_valid_request_data_kwargs():
os.path.join(DIRECTORY, "..", "..", "example-docs", "layout-parser-paper-fast.jpg"), os.path.join(DIRECTORY, "..", "..", "example-docs", "layout-parser-paper-fast.jpg"),
] ]
elements = partition_multiple_via_api(filenames=filenames, api_key="", strategy="fast") elements = partition_multiple_via_api(filenames=filenames, strategy="fast")
assert isinstance(elements, list) assert isinstance(elements, list)
@ -310,6 +306,5 @@ def test_partition_multiple_via_api_invalid_request_data_kwargs():
with pytest.raises(ValueError): with pytest.raises(ValueError):
partition_multiple_via_api( partition_multiple_via_api(
filenames=filenames, filenames=filenames,
api_key="FAKEROO",
strategy="not_a_strategy", strategy="not_a_strategy",
) )

View File

@ -1 +1 @@
__version__ = "0.7.6-dev1" # pragma: no cover __version__ = "0.7.6-dev2" # pragma: no cover