fix: fix partition_via_api retry mechanism when the default SDK's retry config is empty. (#3746)

This commit is contained in:
Pawel Kmiecik 2024-10-24 11:37:22 +02:00 committed by GitHub
parent 0b4c72a618
commit bdfcc14e3d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 32 additions and 2 deletions

View File

@ -1,3 +1,13 @@
## 0.16.2-dev1
### Enhancements
### Features
### Fixes
## **Fixed retry config settings for partition_via_api function** If the SDK's default retry config is not set the retry config getter function does not fail anymore.
## 0.16.1
### Enhancements

View File

@ -246,6 +246,25 @@ def test_retries_config_none_parameters_return_empty_config():
assert retries_config is None
def test_retry_config_with_empty_sdk_retry_config_returns_default():
sdk = Mock()
sdk.sdk_configuration.retry_config = None
retries_config = get_retries_config(
retries_connection_errors=True,
retries_exponent=1.88,
retries_initial_interval=3000,
retries_max_elapsed_time=None,
retries_max_interval=None,
sdk=sdk,
)
assert retries_config.retry_connection_errors
assert retries_config.backoff.exponent == 1.88
assert retries_config.backoff.initial_interval == 3000
assert retries_config.backoff.max_elapsed_time == DEFAULT_RETRIES_MAX_ELAPSED_TIME_SEC
assert retries_config.backoff.max_interval == DEFAULT_RETRIES_MAX_INTERVAL_SEC
def test_retries_config_with_no_parameters_set():
retry_config = retries.RetryConfig(
"backoff", retries.BackoffStrategy(3000, 720000, 1.88, 1800000), True

View File

@ -1 +1 @@
__version__ = "0.16.1" # pragma: no cover
__version__ = "0.16.2-dev1" # pragma: no cover

View File

@ -195,7 +195,8 @@ def get_retries_config(
default_retries_connneciton_errors = (
sdk_default_retries_config.retry_connection_errors
if sdk_default_retries_config.retry_connection_errors is not None
if sdk_default_retries_config
and sdk_default_retries_config.retry_connection_errors is not None
else DEFAULT_RETRIES_CONNECTION_ERRORS
)