mirror of
https://github.com/Unstructured-IO/unstructured.git
synced 2025-07-08 17:46:54 +00:00

This change is adding to our `add_chunking_strategy` logic so that we are able to chunk Table elements' `text` and `text_as_html` params. In order to keep the functionality under the same `by_title` chunking strategy we have renamed the `combine_under_n_chars` to `max_characters`. It functions the same way for the combining elements under Title's, as well as specifying a chunk size (in chars) for TableChunk elements. *renaming the variable to `max_characters` will also reflect the 'hard max' we will implement for large elements in followup PRs Additionally -> some lint changes snuck in when I ran `make tidy` hence the minor changes in unrelated files :) TODO: ✅ add unit tests --> note: added where I could to unit tests! Some unit tests I just clarified that the chunking strategy was now 'by_title' because we don't have a file example that has Table elements to test the 'by_num_characters' chunking strategy ✅ update changelog To manually test: ``` In [1]: filename="example-docs/example-10k.html" In [2]: from unstructured.chunking.title import chunk_table_element In [3]: from unstructured.partition.auto import partition In [4]: elements = partition(filename) # element at -2 happens to be a Table, and we'll get chunks of char size 4 here In [5]: chunks = chunk_table_element(elements[-2], 4) # examine text and text_as_html params ln [6]: for c in chunks: print(c.text) print(c.metadata.text_as_html) ``` --------- Co-authored-by: Yao You <theyaoyou@gmail.com>
296 lines
9.6 KiB
Python
296 lines
9.6 KiB
Python
import os
|
|
import pathlib
|
|
|
|
import msg_parser
|
|
import pytest
|
|
|
|
from unstructured.chunking.title import chunk_by_title
|
|
from unstructured.documents.elements import (
|
|
ElementMetadata,
|
|
ListItem,
|
|
NarrativeText,
|
|
Title,
|
|
)
|
|
from unstructured.partition.json import partition_json
|
|
from unstructured.partition.msg import extract_msg_attachment_info, partition_msg
|
|
from unstructured.partition.text import partition_text
|
|
from unstructured.staging.base import elements_to_json
|
|
|
|
DIRECTORY = pathlib.Path(__file__).parent.resolve()
|
|
EXAMPLE_DOCS_DIRECTORY = os.path.join(DIRECTORY, "..", "..", "..", "example-docs")
|
|
|
|
EXPECTED_MSG_OUTPUT = [
|
|
NarrativeText(text="This is a test email to use for unit tests."),
|
|
Title(text="Important points:"),
|
|
ListItem(text="Roses are red"),
|
|
ListItem(text="Violets are blue"),
|
|
]
|
|
|
|
ATTACH_EXPECTED_OUTPUT = [
|
|
{
|
|
"filename": "fake-attachment.txt",
|
|
"extension": ".txt",
|
|
"file_size": "unknown",
|
|
"payload": b"Hey this is a fake attachment!",
|
|
},
|
|
]
|
|
|
|
|
|
def test_partition_msg_from_filename():
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg")
|
|
elements = partition_msg(filename=filename)
|
|
parent_id = elements[0].metadata.parent_id
|
|
|
|
assert elements == EXPECTED_MSG_OUTPUT
|
|
assert (
|
|
elements[0].metadata.to_dict()
|
|
== ElementMetadata(
|
|
coordinates=None,
|
|
filename=filename,
|
|
last_modified="2022-12-16T17:04:16-05:00",
|
|
page_number=None,
|
|
url=None,
|
|
sent_from=["Matthew Robinson <mrobinson@unstructured.io>"],
|
|
sent_to=["Matthew Robinson (None)"],
|
|
subject="Test Email",
|
|
filetype="application/vnd.ms-outlook",
|
|
parent_id=parent_id,
|
|
).to_dict()
|
|
)
|
|
for element in elements:
|
|
assert element.metadata.filename == "fake-email.msg"
|
|
|
|
|
|
def test_partition_msg_from_filename_returns_uns_elements():
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg")
|
|
elements = partition_msg(filename=filename)
|
|
assert isinstance(elements[0], NarrativeText)
|
|
|
|
|
|
def test_partition_msg_from_filename_with_metadata_filename():
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg")
|
|
elements = partition_msg(filename=filename, metadata_filename="test")
|
|
assert all(element.metadata.filename == "test" for element in elements)
|
|
|
|
|
|
class MockMsOxMessage:
|
|
def __init__(self, filename):
|
|
self.body = "Here is an email with plain text."
|
|
self.header_dict = {"Content-Type": "text/plain"}
|
|
|
|
|
|
def test_partition_msg_from_filename_with_text_content(monkeypatch):
|
|
monkeypatch.setattr(msg_parser, "MsOxMessage", MockMsOxMessage)
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg")
|
|
elements = partition_msg(filename=filename)
|
|
assert str(elements[0]) == "Here is an email with plain text."
|
|
assert elements[0].metadata.filename == "fake-email.msg"
|
|
assert elements[0].metadata.file_directory == EXAMPLE_DOCS_DIRECTORY
|
|
|
|
|
|
def test_partition_msg_raises_with_missing_file():
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "doesnt-exist.msg")
|
|
with pytest.raises(FileNotFoundError):
|
|
partition_msg(filename=filename)
|
|
|
|
|
|
def test_partition_msg_from_file():
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg")
|
|
with open(filename, "rb") as f:
|
|
elements = partition_msg(file=f)
|
|
assert elements == EXPECTED_MSG_OUTPUT
|
|
for element in elements:
|
|
assert element.metadata.filename is None
|
|
|
|
|
|
def test_partition_msg_from_file_with_metadata_filename():
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg")
|
|
with open(filename, "rb") as f:
|
|
elements = partition_msg(file=f, metadata_filename="test")
|
|
assert elements == EXPECTED_MSG_OUTPUT
|
|
for element in elements:
|
|
assert element.metadata.filename == "test"
|
|
|
|
|
|
def test_extract_attachment_info():
|
|
filename = os.path.join(
|
|
DIRECTORY,
|
|
"..",
|
|
"..",
|
|
"..",
|
|
"example-docs",
|
|
"fake-email-attachment.msg",
|
|
)
|
|
attachment_info = extract_msg_attachment_info(filename)
|
|
assert len(attachment_info) > 0
|
|
assert attachment_info == ATTACH_EXPECTED_OUTPUT
|
|
|
|
|
|
def test_partition_msg_raises_with_both_specified():
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg")
|
|
with open(filename, "rb") as f, pytest.raises(ValueError):
|
|
partition_msg(filename=filename, file=f)
|
|
|
|
|
|
def test_partition_msg_raises_with_neither():
|
|
with pytest.raises(ValueError):
|
|
partition_msg()
|
|
|
|
|
|
def test_partition_msg_from_filename_exclude_metadata():
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg")
|
|
elements = partition_msg(filename=filename, include_metadata=False)
|
|
|
|
for i in range(len(elements)):
|
|
assert elements[i].metadata.to_dict() == {}
|
|
|
|
|
|
def test_partition_msg_from_file_exclude_metadata():
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg")
|
|
with open(filename, "rb") as f:
|
|
elements = partition_msg(file=f, include_metadata=False)
|
|
|
|
for i in range(len(elements)):
|
|
assert elements[i].metadata.to_dict() == {}
|
|
|
|
|
|
def test_partition_msg_can_process_attachments(
|
|
tmpdir,
|
|
filename="example-docs/fake-email-attachment.msg",
|
|
):
|
|
extract_msg_attachment_info(filename=filename, output_dir=tmpdir.dirname)
|
|
attachment_filename = os.path.join(
|
|
tmpdir.dirname,
|
|
ATTACH_EXPECTED_OUTPUT[0]["filename"],
|
|
)
|
|
|
|
mocked_last_modification_date = "2029-07-05T09:24:28"
|
|
|
|
attachment_elements = partition_text(
|
|
filename=attachment_filename,
|
|
metadata_filename=attachment_filename,
|
|
metadata_last_modified=mocked_last_modification_date,
|
|
)
|
|
expected_metadata = attachment_elements[0].metadata
|
|
expected_metadata.file_directory = None
|
|
expected_metadata.attached_to_filename = filename
|
|
|
|
elements = partition_msg(
|
|
filename=filename,
|
|
attachment_partitioner=partition_text,
|
|
process_attachments=True,
|
|
metadata_last_modified=mocked_last_modification_date,
|
|
)
|
|
|
|
# This test does not need to validate if hierarchy is working
|
|
# Patch to nullify parent_id
|
|
expected_metadata.parent_id = None
|
|
elements[-1].metadata.parent_id = None
|
|
|
|
assert elements[0].text.startswith("Hello!")
|
|
for element in elements[:-1]:
|
|
assert element.metadata.filename == "fake-email-attachment.msg"
|
|
assert element.metadata.subject == "Fake email with attachment"
|
|
assert elements[-1].text == "Hey this is a fake attachment!"
|
|
assert elements[-1].metadata == expected_metadata
|
|
|
|
|
|
def test_partition_msg_can_process_min_max_wtih_attachments(
|
|
tmpdir,
|
|
filename="example-docs/fake-email-attachment.msg",
|
|
):
|
|
extract_msg_attachment_info(filename=filename, output_dir=tmpdir.dirname)
|
|
attachment_filename = os.path.join(
|
|
tmpdir.dirname,
|
|
ATTACH_EXPECTED_OUTPUT[0]["filename"],
|
|
)
|
|
|
|
attachment_elements = partition_text(
|
|
filename=attachment_filename,
|
|
metadata_filename=attachment_filename,
|
|
min_partition=6,
|
|
max_partition=12,
|
|
)
|
|
|
|
elements = partition_msg(
|
|
filename=filename,
|
|
attachment_partitioner=partition_text,
|
|
process_attachments=True,
|
|
min_partition=6,
|
|
max_partition=12,
|
|
)
|
|
|
|
assert elements[0].text.startswith("Hello!")
|
|
assert elements[-1].text == attachment_elements[-1].text
|
|
assert elements[-2].text == attachment_elements[-2].text
|
|
for element in elements:
|
|
if element.metadata.attached_to_filename is not None:
|
|
assert len(element.text) <= 12
|
|
assert len(element.text) >= 6
|
|
|
|
|
|
def test_partition_msg_raises_with_no_partitioner(
|
|
filename="example-docs/fake-email-attachment.msg",
|
|
):
|
|
with pytest.raises(ValueError):
|
|
partition_msg(filename=filename, process_attachments=True)
|
|
|
|
|
|
def test_partition_msg_from_file_custom_metadata_date(
|
|
filename="example-docs/fake-email.msg",
|
|
):
|
|
expected_last_modification_date = "2020-07-05T09:24:28"
|
|
|
|
with open(filename, "rb") as f:
|
|
elements = partition_msg(
|
|
file=f,
|
|
metadata_last_modified=expected_last_modification_date,
|
|
)
|
|
|
|
assert elements[0].metadata.last_modified == expected_last_modification_date
|
|
|
|
|
|
def test_partition_msg_custom_metadata_date(
|
|
filename="example-docs/fake-email.msg",
|
|
):
|
|
expected_last_modification_date = "2020-07-05T09:24:28"
|
|
|
|
elements = partition_msg(
|
|
filename=filename,
|
|
metadata_last_modified=expected_last_modification_date,
|
|
)
|
|
|
|
assert elements[0].metadata.last_modified == expected_last_modification_date
|
|
|
|
|
|
def test_partition_msg_with_json():
|
|
filename = os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg")
|
|
elements = partition_msg(filename=filename)
|
|
test_elements = partition_json(text=elements_to_json(elements))
|
|
|
|
assert elements == test_elements
|
|
assert elements[0].metadata.sent_from == test_elements[0].metadata.sent_from
|
|
assert elements[0].metadata.sent_to[0] == test_elements[0].metadata.sent_to[0]
|
|
assert elements[0].metadata.subject == test_elements[0].metadata.subject
|
|
|
|
|
|
def test_partition_msg_with_pgp_encrypted_message(
|
|
caplog,
|
|
filename="example-docs/fake-encrypted.msg",
|
|
):
|
|
elements = partition_msg(filename=filename)
|
|
|
|
assert elements == []
|
|
assert "WARNING" in caplog.text
|
|
assert "Encrypted email detected" in caplog.text
|
|
|
|
|
|
def test_add_chunking_strategy_by_title_on_partition_msg(
|
|
filename=os.path.join(EXAMPLE_DOCS_DIRECTORY, "fake-email.msg"),
|
|
):
|
|
elements = partition_msg(filename=filename)
|
|
chunk_elements = partition_msg(filename, chunking_strategy="by_title")
|
|
chunks = chunk_by_title(elements)
|
|
assert chunk_elements != elements
|
|
assert chunk_elements == chunks
|